Aller au contenu principal

πŸ›οΈ Standard Marchemalo β€” Implementation Review Loop

"No code in production without Council validation at 9+/10"

Overview​

Every significant implementation ticket follows an iterative validation loop until achieving a score β‰₯9/10 from the Council.

What is "Significant"?​

A ticket is significant if it meets both criteria:

  • β‰₯3 story points
  • AND at least one of:
    • πŸ”’ Security-related
    • πŸ’₯ Breaking change
    • πŸ†• New pattern (not yet in codebase)
    • πŸ—οΈ Critical infrastructure

The Review Loop​

                    β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”
β”‚ MAX 3 ITERATIONS β”‚
β”‚ (then escalate/split) β”‚
β–Ό β”‚
β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β” β”‚
β”‚ STEP 1: Code Scan β”‚ β”‚
β”‚ β”‚ β”‚
β”‚ β€’ Scan existing structure β”‚ β”‚
β”‚ β€’ Identify patterns to follow β”‚ β”‚
β”‚ β€’ Produce implementation PLAN β”‚ β”‚
β”‚ β€’ Include proposed code β”‚ β”‚
β”‚ β”‚ β”‚
β”‚ ⏱️ Timebox: 2h max β”‚ β”‚
β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜ β”‚
β”‚ β”‚
β–Ό β”‚
β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β” β”‚
β”‚ STEP 2: Council Review β”‚ β”‚
β”‚ β”‚ β”‚
β”‚ JUDGES (context-dependent): β”‚ β”‚
β”‚ β€’ Archi 50x50 (always) β”‚ β”‚
β”‚ β€’ Team Coca (if security) β”‚ β”‚
β”‚ β€’ OSS Killer (if scope/business) β”‚ β”‚
β”‚ β€’ Better Call Saul (if IP/legal) β”‚ β”‚
β”‚ β”‚ β”‚
β”‚ ⏱️ Timebox: 1h max β”‚ β”‚
β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜ β”‚
β”‚ β”‚
β–Ό β”‚
β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β” β”‚
β”‚ STEP 3: Verdict β”‚ β”‚
β”‚ β”‚ β”‚
β”‚ Score = MINIMUM of all reviewers β”‚ β”‚
β”‚ (not average - strictest wins) β”‚ β”‚
β”‚ β”‚ β”‚
β”‚ Score < 9/10 + iteration < 3? β”‚ β”‚
β”‚ β†’ Corrections β†’ Back to STEP 1 β”‚β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜
β”‚ β”‚ LOOP
β”‚ Score < 9/10 + iteration = 3? β”‚
β”‚ β†’ ESCALATE (see below) β”‚
β”‚ β”‚
β”‚ Score β‰₯ 9/10? β”‚
β”‚ β†’ STEP 4 β”‚
β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜
β”‚
β–Ό (Score β‰₯ 9/10 only)
β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”
β”‚ STEP 4: Implementation β”‚
β”‚ β”‚
β”‚ Score 10/10: β”‚
β”‚ β†’ Direct to prod, flag OFF β”‚
β”‚ β”‚
β”‚ Score 9/10: β”‚
β”‚ β†’ Prod with feature flag ON β”‚
β”‚ β†’ Enhanced monitoring 48h β”‚
β”‚ β†’ Post-deploy review β”‚
β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜
β”‚
β–Ό
β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”
β”‚ STEP 5: Capitalization β”‚
β”‚ β”‚
β”‚ If new pattern validated: β”‚
β”‚ β†’ Create ADR β”‚
β”‚ β†’ Add to Patterns Library β”‚
β”‚ β”‚
β”‚ Always: β”‚
β”‚ β†’ Log in review history β”‚
β”‚ β†’ Update metrics β”‚
β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜

Fast-Track (Security Hotfix)​

For critical security hotfixes only:

CriteriaValue
ConditionsActive CVE or ongoing breach, immediate prod impact
ProcessTeam Coca review ONLY
Thresholdβ‰₯8/10 sufficient
Timebox4h max total
Follow-upFull review within 48h post-deploy

Arbitration​

Reviewer Disagreement​

Rule: MINIMUM score prevails.

Example:
Archi 50x50: 9/10
Team Coca: 7/10
OSS Killer: 9/10

β†’ Final score = 7/10 (Team Coca)
β†’ Corrections required on Coca's points

Deadlock (>24h without consensus)​

  1. Each reviewer presents arguments (5min each)
  2. BDFL makes final decision
  3. Decision documented in ADR
  4. No appeal

After 3 Iterations Without β‰₯9/10​

OptionDescription
SPLITBreak ticket into smaller parts
DEFERPostpone to next cycle with new scope
BDFLEscalate for forced decision (rare)

Scoring Scale​

ScoreMeaningActionDeployment
10/10Perfectβœ… ImplementDirect to prod
9/10Excellent β€” minor risks identifiedβœ… ImplementProd + feature flag
8/10Good β€” issues to monitor❌ Corrections(Staging if fast-track)
7/10Acceptable β€” significant issues❌ Correctionsβ€”
<7/10Insufficient❌ Major reworkβ€”

The Council​

Reviewers and Activation​

ReviewerActivated if...Focus
Archi 50x50ALWAYSPatterns, consistency, maintainability
Team CocaTag security OR auth/crypto/inputFull security review
OSS KillerNew feature OR unclear scopeBusiness value, over-engineering
Better Call SaulTag legal OR IP/licensing/dataCompliance, legal risks

Minimum Composition​

Ticket TypeRequired Reviewers
Standard featureArchi
Feature + securityArchi + Team Coca
Feature + new scopeArchi + OSS Killer
Security fixTeam Coca (fast-track possible)
Anything with IP/dataArchi + Better Call Saul

Reviewer Criteria​

Archi 50x50 (40 years XP)​

Criterion10/109/10<9/10
Patterns100% follows existing1 justified deviationInconsistent
Lifecyclestatus + soft delete + audit1 minor missingMajor gaps
ConfigPydantic SettingsAcceptable mixos.getenv everywhere
TestsUnit + Integration + EdgeUnit + IntegrationInsufficient
DocsDocstrings + READMEDocstringsNothing

Team Coca (Security Red Team)​

Score = minimum of all 4 sub-reviewers.

Chucky (Crypto)​

Criterion10/109/10<9/10
Private keyNever stored/loggedβ€”Any violation
EntropyCrypto secureβ€”random()
X.509 extensionsAll presentβ€”Missing

N3m0 (Injection)​

Criterion10/109/10<9/10
Input validationRegex + sanitizeSanitize onlyNone
Injection testsComplete parametrizedBasicNone

Gh0st (Secrets)​

Criterion10/109/10<9/10
LogsNo secretsWarning if debugSecret in logs
ErrorsGeneric messagesβ€”Stack traces

Pr1nc3ss (Access Control)​

Criterion10/109/10<9/10
RBACComplete + testedCompleteMissing
Isolation404 (not 403) + tested404Info disclosure
Rate limitImplementedDocumented TODOAbsent

OSS Killer (Skeptical VC)​

Criterion10/109/10<9/10
ScopeExactly the ticket+1 nice-to-haveScope creep
YAGNINo "just in case" code1 future abstractionOver-engineering
Business valueClear and measurableClearVague
E2E TestsAutomatedSemi-autoManual curl

Review Template​

## Council Review β€” [TICKET-ID] [Title]

**Iteration:** X/3
**Date:** YYYY-MM-DD
**Activated Reviewers:** [Archi] [Coca] [OSS] [Saul]

### Scores

| Reviewer | Score | Blockers | Comment |
|----------|-------|----------|---------|
| Archi 50x50 | X/10 | 0 | ... |
| Team Coca | X/10 | X | ... |
| OSS Killer | X/10 | 0 | ... |

**Final Score: X/10** (minimum)

### P0 Corrections (Blocking for 9+)

1. [ ] ...
2. [ ] ...

### P1 Corrections (Recommended)

1. [ ] ...

### Verdict

- [ ] βœ… **APPROVED 10/10** β€” Direct to prod
- [ ] βœ… **APPROVED 9/10** β€” Prod + feature flag + 48h monitoring
- [ ] ❌ **REJECTED** β€” Corrections required (iteration X/3)
- [ ] 🚨 **ESCALATE** β€” 3 iterations reached, BDFL decision required

### Capitalization

- [ ] New pattern β†’ Create ADR
- [ ] Existing pattern validated β†’ Ref: ADR-XXX

Metrics to Track​

MetricTargetAlert if...
Avg review time<1h>2h
Avg iterations<2>2.5
1st iteration approval rate>30%<20%
BDFL escalation rate<5%>10%
Review/code overhead<30%>50%

Anti-Patterns​

❌ Forbiddenβœ… Alternative
"Good enough for MVP"Simplify scope to reach 9+
"We'll fix in v2"Fix now or split ticket
"Time pressure"Fast-track if truly critical
"It's just internal"Same standard everywhere
"Tests later"Tests in initial plan
"Review = overhead"Review = quality investment

Applicability Matrix​

TypeReview Loop?Reviewers
Feature β‰₯3pts + criterionβœ… YESPer tags
Feature β‰₯3pts simple⚠️ Light ArchiArchi only
Feature <3pts❌ Standard PR reviewβ€”
Security fixβœ… Fast-trackTeam Coca
Critical hotfixβœ… Fast-trackTeam Coca
Major refactorβœ… YESArchi + OSS
Config change⚠️ Per impactArchi
Doc/typo❌ NOβ€”

Storage Locations​

WhatWhere
This standarddocs.gostoa.dev/governance/
Review templateLinear (ticket template)
Review historyNotion (confidential, CIR)
MetricsGrafana dashboard
ADRsdocs.gostoa.dev/adr/
Patterns Librarydocs.gostoa.dev/patterns/

Changelog​

v1.1 (2026-01-28)​

  • Changed threshold from 10/10 to 9/10 (pragmatic)
  • Added timeboxing: max 3 iterations
  • Added arbitration: minimum score + BDFL escalation
  • Added fast-track for security hotfixes
  • Refined scope: β‰₯3pts AND (security OR breaking OR new pattern)
  • Added capitalization: ADR + Patterns Library
  • Added tracking metrics

v1.0 (2026-01-28)​

  • Initial version
  • Reviewed by OSS Killer (7/10) and Archi 50x50 (8/10)
  • Did not pass its own test β†’ v1.1 created